#78 Increase playwright test timeout to make CI more reliable #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallwhiteorg
requested review from
edublancas,
idomic,
neelasha23 and
bryannho
Open
|
Will this work in case of intermittent failures? I think the time-outs happen in these failure cases, and it's only going to increase the time for the CI to fail. |
|
@neelasha23 Yeah it is unlikely to work, just wanted to try, was not sure how to run the CI without making a pull request I'm running the CI a few times to see what changes |
|
@neelasha23 it didn't work, will need to take a different approach https://github.com/ploomber/jupysql-plugin/actions/runs/6401180754/job/17378192452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Increase playwright test timeout to make CI more reliable. This is going to make them slower as well.
We should fix the underlying issue.
Issue number
Closes #78
Checklist before requesting a review
pkgmt format