Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create table explorer (%sqlcmd explore) #330

Closed
edublancas opened this issue Mar 27, 2023 · 4 comments · Fixed by #420
Closed

create table explorer (%sqlcmd explore) #330

edublancas opened this issue Mar 27, 2023 · 4 comments · Fixed by #420
Assignees

Comments

@edublancas
Copy link

edublancas commented Mar 27, 2023

context: #146 (comment)

cc @idomic

--

Executing %sqlcmd explore --table table --schema schema should display an HTML view of the table, users should be able to sort each column by clicking on the header and control the number of displayed items (e.g., 10, 20, 30) and move to the next set of images. Pretty much like this, except we won't include the search field in this iteration.

Interacting with the table (e.g., sorting a column) should trigger the execution of a SQL query, results should be fetched and the table must be updated. In other words, no processing should happen locally, everything should be computed in the SQL engine.

The feature should be complemented with a tutorial in the documentation. Most likely, the interactive component won't be visible from the tutorial so we should tell users to open it on Binder to see it in action.

There should also be detailed tests, although this is open for discussion since I'm unsure how we can simulate users clicking on the table.

@idomic
Copy link

idomic commented Mar 27, 2023

Hmm why a new one? I kept the original open: #136
I guess the title is more explicit

@edublancas
Copy link
Author

The context got lost, I wanna make sure we are on the same page in terms of what to build: #146 (comment)

@idomic
Copy link

idomic commented Apr 7, 2023

@edublancas please set the criteria we want here, here's what I'm assuming:

  1. A working design of the feature.
  2. Extensive tests
  3. Document how to use it.

@edublancas
Copy link
Author

Updated the top comment with the acceptance criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants