Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when using --save and writing a CTE #652

Closed
edublancas opened this issue Jun 23, 2023 · 5 comments · Fixed by #878
Closed

error when using --save and writing a CTE #652

edublancas opened this issue Jun 23, 2023 · 5 comments · Fixed by #878
Assignees
Labels
stash Label used to categorize issues that will be worked on next

Comments

@edublancas
Copy link

(similar to #651, let's work on that one first)

more context: create-table-bug-2.ipynb.zip

@edublancas edublancas added the stash Label used to categorize issues that will be worked on next label Jun 23, 2023
@nooodle-soup
Copy link

Hey @edublancas
I checked out the file and only the last cell is still creating an error when I ran it. Please confirm if it is the same for you. The last second cell error seems to have been resolved by a previous update.

@edublancas
Copy link
Author

if the first example has been fixed, just make sure we have a unit test for it (it might be in the test_magic.py file. And then focus on fixing the second case

@nooodle-soup
Copy link

Still working on the first one
Unsure where to start
#651 brought me here so thought to check it if I can find a lead

@nooodle-soup
Copy link

nooodle-soup commented Sep 9, 2023

@edublancas Do we want to show a warning or raise a usage error if we are disabling the CTE when a saved snippet is used in the expression?

@edublancas
Copy link
Author

we show a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stash Label used to categorize issues that will be worked on next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants