Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helping users when setting their key #1058

Closed
edublancas opened this issue Jan 3, 2023 · 2 comments
Closed

helping users when setting their key #1058

edublancas opened this issue Jan 3, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@edublancas
Copy link
Contributor

I got a report from a cloud user that they had a "malformed API key error", somewhere in our docs, we have the following instructions:

ploomber cloud set-key {your-key}

And the user was setting it with the {} characters. We should detect if the passed key begins with { and ends with }. If so, ignore those characters (or maybe show an error telling them to remove them?)

@idomic
Copy link
Contributor

idomic commented Jan 3, 2023

I think we can simply solve it with a comment in the guide, something along the lines:

# example: ploomber cloud set-key ABI8475@ODMFMOMD

@tonykploomber
Copy link
Contributor

I think we should apply both:
Providing the example in guide + {} characters error detection

@edublancas edublancas added bug Something isn't working good first issue Good for newcomers labels May 23, 2023
@edublancas edublancas closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants