Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_finish argument to Task constructor #15

Closed
edublancas opened this issue Feb 27, 2020 · 1 comment
Closed

Add on_finish argument to Task constructor #15

edublancas opened this issue Feb 27, 2020 · 1 comment

Comments

@edublancas
Copy link
Contributor

Related to #14

Currently, the only way to add an on_finish hook to as ask is:

task.on_finish = some_callable

Even though that API is fine, it should also be possible to add it in the Task's constructor:

Task(..., on_finish=some_callable)
@edublancas
Copy link
Contributor Author

We want to keep constructor parameters at minimum, there isn't any strong reason to have all hooks as init parameters when they can be set via properties. closing ths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant