Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when dotted path fails to load. Also, added respective tests for the same. #410

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

abhishak3
Copy link
Contributor

@abhishak3 abhishak3 commented Oct 30, 2021

Included path of the module in the error message imported through the load_dotted_path method. Also, added tests for the same.

Resolves #405

@edublancas
Copy link
Contributor

adding the tag so it counts for hacktoberfest :) will review later

@abhishak3
Copy link
Contributor Author

Thanks a lot !

@edublancas edublancas changed the base branch from master to dotted-path-error-msg January 4, 2022 01:37
@edublancas edublancas merged commit 49afeda into ploomber:dotted-path-error-msg Jan 4, 2022
@edublancas
Copy link
Contributor

thanks @abhishak3!

edublancas added a commit that referenced this pull request Jan 4, 2022
Co-authored-by: Eduardo Blancas <github@blancas.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when dotted path fails to load
2 participants