Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook static analysis refactoring #566

Closed
4 tasks done
edublancas opened this issue Feb 9, 2022 · 0 comments
Closed
4 tasks done

notebook static analysis refactoring #566

edublancas opened this issue Feb 9, 2022 · 0 comments
Milestone

Comments

@edublancas
Copy link
Contributor

edublancas commented Feb 9, 2022

We'll make a few changes to the way notebook static analysis behaves. It'll have three values now:

  1. 'regular' - raise a warning at render time, raise an error at runtime (default)
  2. 'strict' / True - raise an exception if there is an error at render time or runtime
  3. 'disabled' / False - do not run static analysis

We make this change to allow users to run some of the commands that only require rendering because the current default value is too strict: if the pipeline has at least one notebook with a problem, users cannot even run ploomber status or ploomber plot

TO DOs:

  • make the changes in the code
  • update tests
  • map boolean values to maintain backward compatibility
  • improve error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant