Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the {{git}} placeholder feature #667

Merged
merged 14 commits into from
Mar 22, 2022
Merged

Improvements to the {{git}} placeholder feature #667

merged 14 commits into from
Mar 22, 2022

Conversation

edublancas
Copy link
Contributor

This PR improves the {{git}} placeholder feature:

  • Adds {{git_hash}} which is slightly different in behavior
  • Outputs better error messages (e.g. git not installed, not in a valid repo)
  • No longer requires an env.yaml: the placeholder can be directly used in pipeline.yaml

For a usage example, see: https://github.com/ploomber/projects/blob/versioning/guides/versioning/README.ipynb

@edublancas edublancas requested a review from idomic March 20, 2022 14:36
idomic
idomic approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@idomic idomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure the CI is passing

@edublancas edublancas merged commit 6e7ae7c into master Mar 22, 2022
@edublancas edublancas deleted the git branch March 22, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idomic idomic idomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edublancas @idomic