Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify casing in Chart APIs #105

Closed
kMutagene opened this issue Aug 5, 2021 · 1 comment · Fixed by #114
Closed

Unify casing in Chart APIs #105

kMutagene opened this issue Aug 5, 2021 · 1 comment · Fixed by #114

Comments

@kMutagene
Copy link
Member

kMutagene commented Aug 5, 2021

Description

Basically all Chart extension functions should be lower camel case (Chart.someFunctionName). The API is kind of inconsistent in that regard:

see e.g.Chart.Show or Chart.Combine vs. Chart.withTitle or Chart.withX_AxisStyle

This is a change that is absolutely not backwards compatible but i think it should be done before finally releasing 2.0.0

However, i would keep the core Chart API the same to make the those look more like constructors (meaning we keep Chart.Point, Chart.Line, etc.)

@kMutagene kMutagene added this to the 2.0 milestone Aug 5, 2021
This was referenced Aug 6, 2021
@WhiteBlackGoose
Copy link
Contributor

WhiteBlackGoose commented Aug 10, 2021

As per discord discussion: types like FontFamily , Fill and where needed to be named consistent with F# (with no underscores)
there will be a new issue for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants