Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extract-meta into its own NPM module #17

Closed
wilzbach opened this issue Oct 11, 2018 · 2 comments
Closed

Move extract-meta into its own NPM module #17

wilzbach opened this issue Oct 11, 2018 · 2 comments

Comments

@wilzbach
Copy link

It would be great if the entire meta-generation pipeline would be separated in its own package, s.t. upgrade to future versions of dash-component-boilerplate will be as easy as bumping the version number.

In other words, I think at least extract-meta should be shipped as a package and not be part of the boilerplate. This would also make the pipeline more future proof in case you will change/improve the extract-meta script.

A more radical script would be to move in the direction of react-scripts which also abstracts away most of the configuration (like e.g. the webpack configuration - https://github.com/facebook/create-react-app/tree/master/packages/react-scripts/config) and thus allows them to ship new pipeline improvements to all users.
This is sth. that due to the ever-growing complexity of JS build tools (hello Babel 7) the majority of the user base really likes.

@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 11, 2018

Agreed, with #14 I changed a bit the extract-meta script to include a validation step and added another script to validate the components assets. They could be refactored in a dash-components-scripts package that can be installed in all the components repo so they can get updates.

@rmarren1
Copy link
Contributor

+1 for this, updating the test metadata.json for dash was a bit hacky because this script isn't in its own package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants