Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Multi row copy/paste inserts '\r' on paste for the last selected column #88

Closed
Marc-Andre-Rivet opened this issue Sep 13, 2018 · 2 comments
Assignees

Comments

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Sep 13, 2018

Found while working on Issue #75.

Select at least two rows of cells and copy paste -- the inner html of the cell-value element contains pending '\r' that was inserted by our custom copy logic here:

    const value = R.slice(
        R.head(selectedRows) as any,
        R.last(selectedRows) as any + 1,
        dataframe
    ).map(row =>
        R.props(selectedCols, R.props(R.pluck('id', columns) as any, row) as any)
    ).map(row => R.values(row).join('\t')
    ).join('\r\n');

SheetClip provides a stringify function along with the parse function, we should use that instead of our custom logic.

@Marc-Andre-Rivet Marc-Andre-Rivet self-assigned this Sep 13, 2018
@Marc-Andre-Rivet
Copy link
Contributor Author

In PR #87

@Marc-Andre-Rivet
Copy link
Contributor Author

@cldougl Suggest making this no less than a p2 as it introduces invalid data in the dataframe and the workaround is painful (copy/paste single row only)

@cldougl cldougl added the p1 label Sep 13, 2018
@cldougl cldougl closed this as completed Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants