Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey Vertical Orientation #1023

Closed
bcdunbar opened this issue May 23, 2017 · 19 comments
Closed

Sankey Vertical Orientation #1023

bcdunbar opened this issue May 23, 2017 · 19 comments

Comments

@bcdunbar
Copy link

Horizontal sankey works as expected. But when set to vertical, only nodes not links, update to vertical orientation.

p <- plot_ly(
  type = 'sankey',
  orientation = "v",
  node = list(
    label =  c("a","b", "c", "d", "e", "f", "g", "h"),
    color =  c("black","black","black","black","black","black",
               "black","black"),
    pad = 15,
    thickness = 15,
    line = list(
      color = "black",
      width = 0.5
    )
  ),
  link = list(
    source =  c(0,1,1,3,3,5,5),
    target =  c(1,2,3,4,5,6,7),
    value =  c(1,0.64,0.36,.33,.67,.16,.84))
)
@cpsievert
Copy link
Collaborator

Hmm, is this not what you see?

screen shot 2017-05-23 at 1 18 30 pm

@bcdunbar
Copy link
Author

hmm, nope. I get:

2017-05-23

@cpsievert
Copy link
Collaborator

Try grabbing the latest dev version?

@bcdunbar
Copy link
Author

same issue. sessionInfo():

R version 3.3.1 (2016-06-21)
Platform: i386-w64-mingw32/i386 (32-bit)
Running under: Windows >= 8 x64 (build 9200)

locale:
[1] LC_COLLATE=English_Australia.1252  LC_CTYPE=English_Australia.1252   
[3] LC_MONETARY=English_Australia.1252 LC_NUMERIC=C                      
[5] LC_TIME=English_Australia.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] plotly_4.7.0       ggplot2_2.2.1.9000

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.10      knitr_1.15.1      magrittr_1.5      devtools_1.12.0  
 [5] munsell_0.4.3     xtable_1.8-2      viridisLite_0.2.0 colorspace_1.2-7 
 [9] R6_2.2.0          rlang_0.1.1       httr_1.2.1        plyr_1.8.4       
[13] dplyr_0.5.0       tools_3.3.1       grid_3.3.1        gtable_0.2.0     
[17] DBI_0.5-1         git2r_0.15.0      withr_1.0.2       crosstalk_1.0.1  
[21] htmltools_0.3.6   yaml_2.1.13       lazyeval_0.2.0    digest_0.6.12    
[25] assertthat_0.1    tibble_1.3.1      shiny_1.0.1       tidyr_0.6.3      
[29] purrr_0.2.2.2     htmlwidgets_0.8   curl_2.1          mime_0.5         
[33] memoise_1.0.0     scales_0.4.1      jsonlite_1.4      httpuv_1.3.3

@cpsievert
Copy link
Collaborator

cpsievert commented May 23, 2017

Thanks, can you please provide devtools::session_info() as well?

@cpsievert
Copy link
Collaborator

Also, does the issue persist in multiple web browsers?

@bcdunbar
Copy link
Author

Okay, updated everything! Issue is unique to my RStudio Viewer.

Session info ------------------------------------------------------------------------
 setting  value                       
 version  R version 3.4.0 (2017-04-21)
 system   x86_64, mingw32             
 ui       RStudio (1.0.143)           
 language (EN)                        
 collate  English_Australia.1252      
 tz       America/New_York            
 date     2017-05-23                  

Packages ----------------------------------------------------------------------------
 package     * version    date       source                            
 assertthat    0.2.0      2017-04-11 CRAN (R 3.4.0)                    
 backports     1.1.0      2017-05-22 CRAN (R 3.4.0)                    
 base        * 3.4.0      2017-04-21 local                             
 colorspace    1.3-2      2016-12-14 CRAN (R 3.4.0)                    
 compiler      3.4.0      2017-04-21 local                             
 crosstalk     1.0.0      2016-12-21 CRAN (R 3.4.0)                    
 curl          2.6        2017-04-27 CRAN (R 3.4.0)                    
 datasets    * 3.4.0      2017-04-21 local                             
 DBI           0.6-1      2017-04-01 CRAN (R 3.4.0)                    
 devtools      1.13.1     2017-05-13 CRAN (R 3.4.0)                    
 digest        0.6.12     2017-01-27 CRAN (R 3.4.0)                    
 dplyr         0.5.0      2016-06-24 CRAN (R 3.4.0)                    
 evaluate      0.10       2016-10-11 CRAN (R 3.4.0)                    
 ggplot2     * 2.2.1.9000 2017-05-23 Github (tidyverse/ggplot2@f4398b6)
 git2r         0.18.0     2017-01-01 CRAN (R 3.4.0)                    
 graphics    * 3.4.0      2017-04-21 local                             
 grDevices   * 3.4.0      2017-04-21 local                             
 grid          3.4.0      2017-04-21 local                             
 gtable        0.2.0      2016-02-26 CRAN (R 3.4.0)                    
 htmltools     0.3.6      2017-04-28 CRAN (R 3.4.0)                    
 htmlwidgets   0.8        2016-11-09 CRAN (R 3.4.0)                    
 httpuv        1.3.3      2015-08-04 CRAN (R 3.4.0)                    
 httr          1.2.1      2016-07-03 CRAN (R 3.4.0)                    
 jsonlite      1.4        2017-04-08 CRAN (R 3.4.0)                    
 knitr         1.16       2017-05-18 CRAN (R 3.4.0)                    
 labeling      0.3        2014-08-23 CRAN (R 3.4.0)                    
 lazyeval      0.2.0      2016-06-12 CRAN (R 3.4.0)                    
 magrittr      1.5        2014-11-22 CRAN (R 3.4.0)                    
 memoise       1.1.0      2017-04-21 CRAN (R 3.4.0)                    
 methods     * 3.4.0      2017-04-21 local                             
 mime          0.5        2016-07-07 CRAN (R 3.4.0)                    
 munsell       0.4.3      2016-02-13 CRAN (R 3.4.0)                    
 plotly      * 4.7.0      2017-05-23 Github (ropensci/plotly@2cea2f8)  
 plyr          1.8.4      2016-06-08 CRAN (R 3.4.0)                    
 purrr         0.2.2.2    2017-05-11 CRAN (R 3.4.0)                    
 R6            2.2.1      2017-05-10 CRAN (R 3.4.0)                    
 Rcpp          0.12.10    2017-03-19 CRAN (R 3.4.0)                    
 rlang         0.1.1      2017-05-18 CRAN (R 3.4.0)                    
 rmarkdown     1.5        2017-04-26 CRAN (R 3.4.0)                    
 rprojroot     1.2        2017-01-16 CRAN (R 3.4.0)                    
 rstudioapi    0.6        2016-06-27 CRAN (R 3.4.0)                    
 scales        0.4.1      2016-11-09 CRAN (R 3.4.0)                    
 shiny         1.0.3      2017-04-26 CRAN (R 3.4.0)                    
 stats       * 3.4.0      2017-04-21 local                             
 stringi       1.1.5      2017-04-07 CRAN (R 3.4.0)                    
 stringr       1.2.0      2017-02-18 CRAN (R 3.4.0)                    
 tibble        1.3.1      2017-05-17 CRAN (R 3.4.0)                    
 tidyr         0.6.3      2017-05-15 CRAN (R 3.4.0)                    
 tools         3.4.0      2017-04-21 local                             
 utils       * 3.4.0      2017-04-21 local                             
 viridisLite   0.2.0      2017-03-24 CRAN (R 3.4.0)                    
 withr         1.0.2      2016-06-20 CRAN (R 3.4.0)                    
 xtable        1.8-2      2016-02-05 CRAN (R 3.4.0)                    
 yaml          2.1.14     2016-11-12 CRAN (R 3.4.0)

@cpsievert
Copy link
Collaborator

Thanks. Do you see anything in the console if you right-click -> inspect element -> console?

@bcdunbar
Copy link
Author

Nope, no errors.

@cpsievert
Copy link
Collaborator

@monfera any ideas why this issue would be unique to RStudio on a windows machine?

@cpsievert
Copy link
Collaborator

And for the record, 7c6c4d3 removes the cartesian axes being shown by default in those screenshots

@monfera
Copy link

monfera commented May 24, 2017

@cpsievert it looks like the particular version of IE that's used by the particular RStudio version has no support for the CSS transform style. From that I guess it might be IE9 which I think requires a prefix. I could switch to an SVG attribute for the matrix transform but the visuals will differ. Will think up something; in the meantime if you can confirm the IE version it might help.

@cpsievert
Copy link
Collaborator

@monfera interesting, thanks! I didn't know RStudio used IE on Windows. @monfera could you help @bcdunbar report his version?

@bcdunbar
Copy link
Author

Okay, it may be this:

Microsoft Edge 38.14393.1066.0
Microsoft EdgeHTML 14.14393

@monfera
Copy link

monfera commented May 24, 2017

@bcdunbar thanks! I suppose that you experience the same issue in a standalone (non-RStudio) Microsoft Edge version too? E.g. when visiting this codepen. If this is the case I can make a test bundle in a separated codepen just to make sure that makes the basic issue go away.

@bcdunbar
Copy link
Author

bcdunbar commented May 24, 2017

@monfera Yeah issue persists in standalone Edge version too.

2017-05-24

@monfera
Copy link

monfera commented May 24, 2017

@bcdunbar would you mind taking a look at this? http://codepen.io/anon/pen/pPYvLj

@bcdunbar
Copy link
Author

bcdunbar commented May 24, 2017

@monfera yup vertical orientation is working in that one.

2017-05-24 1

@cpsievert
Copy link
Collaborator

should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants