Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scattergl fill tozerox/y doesn't work as expected #1334

Closed
cldougl opened this issue Jan 25, 2017 · 7 comments
Closed

Scattergl fill tozerox/y doesn't work as expected #1334

cldougl opened this issue Jan 25, 2017 · 7 comments
Milestone

Comments

@cldougl
Copy link
Member

cldougl commented Jan 25, 2017

scattergl fill tozeroy fills to lowest y value rather than 0 and behaves inconsistently from scatter fill which uses the trace as a bound (see codepen: http://codepen.io/plotly/pen/apyXpW?editors=1010 )

Additionally, we need to fix the attribute description for scattergl fill - it should be different from scatter's fill.

@etpinard etpinard added this to the On-par gl2d milestone Jan 30, 2017
@cldougl cldougl removed the type: bug label Feb 6, 2017
@etpinard
Copy link
Contributor

maybe we should try to make a push for this in #1869

cc @dfcreative

@zhangjiang2013
Copy link

Also, the "toself" fill option doesn't work as expected. The enclosed area isn't filled.

@dy
Copy link
Contributor

dy commented Oct 1, 2017

Yes, regl-line2d is capable of filling any shapes now, so fully svg-compatible in that sense. We can cover these cases.

@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2018

@dfcreative 's regl-based scattergl work will get us very close to parity with SVG scatter.

I found a few discrepancies:

From https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_no_opacity, applying Plotly.restyle(gd, 'type', 'scattergl') gives:

image

In https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_self_next, it appears that the bounding lines coloring in gl is blended a little bit. See svg:

image

vs gl (ignore the lack of line.shape)

image

@dy
Copy link
Contributor

dy commented Jan 13, 2018

@etpinard 3b08da1 should fix both. Although https://rreusser.github.io/plotly-mock-viewer/#scatter_fill_no_opacity does not fail now, it requires detailed consideration. I get
image

although regular scatter gives (the case of creased shape)
image

I guess that should be addressed in a separate issue.

@dy
Copy link
Contributor

dy commented Jan 18, 2018

Added mock test d3fd7d2
image

@etpinard
Copy link
Contributor

I'm going to close this thing as the issue title refers to to-zero fills which are fixed in #2258

For more fill open items, see #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants