Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash SVG points selections for faster pan #2548

Closed
etpinard opened this issue Apr 11, 2018 · 1 comment · Fixed by #2623
Closed

Stash SVG points selections for faster pan #2548

etpinard opened this issue Apr 11, 2018 · 1 comment · Fixed by #2623

Comments

@etpinard
Copy link
Contributor

PR #2527 introduced a 'draggedPts' trace category (see #2527 (comment)) which was later deemed a potential overkill by @alexcjohnson in #2527 (comment) to make the pan hot code path avoid large .selectAll() (which can be very slow).

What we should try to do instead is: stash those points selections (probably in fullLayout._plots[subplotId]) early (probably during the trace plot step) and use them directly in pan (and scroll?) hot code path.

@etpinard
Copy link
Contributor Author

While doing this, we should investigate ways to remove more things from that hot pan code path like various fullLayout._has return values (mentioned here).

Moreover, we could perhaps improve performance even more by combining Drawing.setScale and Drawing.setTranslate into one method (ref).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant