Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transforms attribute from PlotSchema for traces that don't support them #3188

Closed
antoinerg opened this issue Oct 30, 2018 · 2 comments

Comments

@antoinerg
Copy link
Contributor

In the process of reviewing PR #3158, @etpinard pointed out that some traces don't support transforms yet it's listed in their PlotSchema (#3158 (comment))

Note that they are properly removed from _fullData:

plotly.js/src/plots/plots.js

Lines 1224 to 1230 in 0124828

plots.supplyTransformDefaults = function(traceIn, traceOut, layout) {
// For now we only allow transforms on 1D traces, ie those that specify a _length.
// If we were to implement 2D transforms, we'd need to have each transform
// describe its own applicability and disable itself when it doesn't apply.
// Also allow transforms that make their own data, but not in globalTransforms
if(!(traceOut._length || hasMakesDataTransform(traceIn))) return;

@etpinard
Copy link
Contributor

Somewhat overlaps with #2908, in particular #2908 (comment)

@antoinerg
Copy link
Contributor Author

Closing in favor of #2908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants