Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funnel hoverinfo incomplete #3954

Closed
nicolaskruchten opened this issue Jun 12, 2019 · 7 comments · Fixed by #3958
Closed

Funnel hoverinfo incomplete #3954

nicolaskruchten opened this issue Jun 12, 2019 · 7 comments · Fixed by #3958
Assignees

Comments

@nicolaskruchten
Copy link
Member

In building the RCE controls for funnel I notice that this requirement wasn't met: #3504 (comment) ... I can't turn the three percentages on or off via the hoverinfo flaglist as far as I can tell.

@archmoj
Copy link
Contributor

archmoj commented Jun 12, 2019

Is there is a similar issue with bar and waterfall?

@nicolaskruchten
Copy link
Member Author

We didn't discuss anything specific for waterfall, but we could discuss it later. Let's fix the funnel case for now please, as it's a well-spec'ed requirement we already agreed to :)

@archmoj
Copy link
Contributor

archmoj commented Jun 12, 2019

Should we add hoverinfo flags (initial | previous | total) for each of those percentages or turning off the three using none or skip is enough?

@nicolaskruchten
Copy link
Member Author

All three please, same as textinfo, just like in the spec :)

@nicolaskruchten
Copy link
Member Author

Question: is it possible to access these via hovertemplate in some way?

@etpinard
Copy link
Contributor

Question: is it possible to access these via hovertemplate in some way?

We can make that possible, yes!

@archmoj archmoj self-assigned this Jun 12, 2019
@nicolaskruchten
Copy link
Member Author

Thanks! The hoverinfo thing is pretty important, the hovertemplate is more of a nice-to-have. I'd say more generally that as a rule, anything that is accessible to hoverinfo should be accessible to hovertemplate. Should I create a separate issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants