Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data array attributes should support Typed arrays (e.g. Float32Array) #860

Closed
joshua-gould opened this issue Aug 17, 2016 · 2 comments
Closed
Assignees

Comments

@joshua-gould
Copy link
Contributor

http://codepen.io/anon/pen/wWOmNQ

@etpinard etpinard changed the title Typed arrays (e.g. Float32Array) do not work as data sources Data array attributes should support Typed arrays (e.g. Float32Array) Aug 17, 2016
@etpinard etpinard mentioned this issue Sep 1, 2016
4 tasks
@monfera
Copy link
Contributor

monfera commented Sep 22, 2016

@joshua-gould Thanks for your report, iirc @etpinard answered but I don't see it here, just wanted to mention that typed arrays are not yet supported except for pointcloud (typed array demo here).

However there are plans to introduce this option. The approach isn't to just not fail when a typed array is supplied, but also, to handle things efficiently with typed arrays in mind, at least for plots where performance matters. For this reason there's no imminent plan to map typed arrays into untyped arrays just to make it work, because the API might change somewhat, similar to how pointcloud has an xy typed array attribute instead of a separate x and y attribute.

@etpinard
Copy link
Contributor

Initial support for typed arrays got added for #2388

Discussion on JSON-serializable typed array data should continue in #1784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants