Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply consistent F# Style #55

Closed
bvenn opened this issue Dec 9, 2020 · 2 comments
Closed

Apply consistent F# Style #55

bvenn opened this issue Dec 9, 2020 · 2 comments

Comments

@bvenn
Copy link
Collaborator

bvenn commented Dec 9, 2020

Description

To ensure consistent F# style, the usage of underscores should be avoided (except for wildcards).

Examples:

  • Chart.WithX_Axis
  • Chart.WithX_AxisStyle
  • ...
@bvenn bvenn mentioned this issue Dec 9, 2020
Closed
13 tasks
@dsyme
Copy link

dsyme commented Dec 10, 2020

Tbh exceptions can be made for this rule - eg the need for name disambiguation in a generated API may make underscores the best solution.

So don't feel like you have to be ultra strict on this

@WhiteBlackGoose
Copy link
Contributor

Should it be closed then now?

@bvenn bvenn closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsyme @bvenn @WhiteBlackGoose