Get remaining trace types integrated

[VeraZab]

there's 19 chart types left to integrate
@bpostlethwaite @nicolaskruchten if we each take about 6 to integrate, then we'll have all of the current ones of the workspace done.

I'll take the finance ones, tables, and ternary.
@nicolaskruchten @bpostlethwaite which ones could you take?

Checklist:

• error bars
• heatmap
• contour
• ternary
• 3d scatter
• 3d line
• 3d surface
• 3d mesh
• animation (to look at when we look at mobile breakpoints // aggregations // transforms)
• timeseries
• candlestick
• ohlc
• histogram
• box plot
• table (need plotly.js 1.34)
• 2d histogram heatmap
• choropleth
• atlas maps
• satellite maps

[bpostlethwaite]

I can take maps!

[bpostlethwaite]

(I suggest all the 'z' type plots get done at once as well - heatmap, contour and 3D surface)

[nicolaskruchten]

I can take the 'z' types and ternary :)

[nicolaskruchten]

Ah, sorry @VeraZab I see you want ternary, no prob.

[nicolaskruchten]

Are there any other non-obvious dependencies among the chart types? special widgets that certain types share or something?

[bpostlethwaite]

@nicolaskruchten mixed bag. I think our groupings have resolved most of that though.

Also while we are only aiming for workspace parity at this stage the workspace has fallen woefully behind plotly.js. It might be worth scanning plotly src for attributes and and these attributes even if the workspace doesn't currently support them. I'll post some links to attribute src code

[VeraZab]

there's for sure attributes that the workspace doesn't currently support 'by design' (we just chose not to because that made for a lot of styling options), but I think our strategy now is to explicitly state in the code, which ones we're not displaying to the user.

Still have to see where we do that in the code, but for sure we're going to encounter that.

Alright, thanks guys, we can see how to deal with the rest of chart types as we go, and if one of us sees that someone else has claimed a chart type that it makes more sense to integrate in the batch that we're doing, then we can just ping each other and switch.

[bpostlethwaite]

to look up attributes in plotly.js look inside each of these folders https://github.com/plotly/plotly.js/tree/master/src/traces for a file called attributes.js. If the trace adds special layout attributes it will be in a file called something like
layout_attributes.js

[nicolaskruchten]

I'll grab 3d{scatter, line, mesh} now.

[VeraZab]

taking ternary next

[VeraZab]

I'm going to take on the 3d's @nicolaskruchten if it's ok with you. That will be another chart type to test with axes.

[VeraZab]

doing histogram creation and styling next

[VeraZab]

animations now

[nicolaskruchten]

in chasing down #293 I went to get some advice from @jackparmer and the conclusion of that discussion was that it was probably a good idea to drop timeseries and animations from the list of "trace types" given that they aren't really trace types and they aren't well-defined in terms of round-tripping from the figure object to UI state and back. I'm very much in favour of this :)

Animations probably should live in its own panel under Create.

[jackparmer]

👍 I'd rather spend time integrating these pure trace types than hacking in the franken-traces that will likely add complexity and be more error prone.

[nicolaskruchten]

Basically all the commented-out ones here: https://github.com/plotly/react-plotly.js-editor/blob/master/src/components/fields/TraceSelector.js#L20

[VeraZab]

Animations probably should live in its own panel under Create.

That sounds good! Maybe it should even be a top level menu like Graph, Styles. Because you can animate both data & layout, but workspace only has data animations now.

[VeraZab]

I'm going to close this and open an issue just for integrating 'tables' which is the only not yet supported chart type by the editor that is currently in the workspace.

(#335)