Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotly.js now prunes unsupported global-level trace attributes #783

Open
antoinerg opened this issue Oct 31, 2018 · 3 comments
Open

plotly.js now prunes unsupported global-level trace attributes #783

antoinerg opened this issue Oct 31, 2018 · 3 comments

Comments

@antoinerg
Copy link

antoinerg commented Oct 31, 2018 •
edited

Just a heads up that we made some changes to the _fullData and PlotSchema in plotly.js: we now remove some global-level trace attributes that weren't supported at the individual trace level. Discussion about this issue is still going there: plotly/plotly.js#3058. PR plotly/plotly.js#3158 which is now released in v.1.42.1 partially closes the aforementioned issue.
@antoinerg
Copy link
Author

A summary of PR plotly/plotly.js#3158 can be found here: plotly/plotly.js#3058 (comment)

@nicolaskruchten
Copy link
Member

@dmt0 can you take a look at this sometime and see if this causes issues for us?

@dmt0 dmt0 self-assigned this Nov 1, 2018
@dmt0
Copy link
Collaborator

dmt0 commented Nov 1, 2018

I imagine percy would tell us if anything would go wrong. But, yes, I'll look around.

@dmt0 dmt0 removed their assignment Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolaskruchten @antoinerg @dmt0