Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitRef struct is wrong #56

Open
edison-moreland opened this issue Nov 1, 2019 · 0 comments
Open

CommitRef struct is wrong #56

edison-moreland opened this issue Nov 1, 2019 · 0 comments

Comments

@edison-moreland
Copy link

First off, this project has been a life saver! I started writing something similar for my small project but that started getting too big. I ran into a bit of an issue try to get commit refs

According to the docs the response from GET /projects/:id/repository/commits/:sha/refs looks like this:

[
  {"type": "branch", "name": "'test'"},
  {"type": "branch", "name": "add-balsamiq-file"},
  {"type": "branch", "name": "wip"},
  {"type": "tag", "name": "v1.1.0"}
]

Which is not the same as CommitRef{} :

type CommitRef struct {
	Id   string `json:"id" yaml:"id"`
	Sha  string `json:"sha" yaml:"sha"`
	Type string `json:"type" yaml:"type"`
}

I'd be happy to make a pull request with an accurate struct. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant