Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepoCommits() missing parameter #59

Open
leiyue1989 opened this issue Aug 26, 2020 · 3 comments
Open

RepoCommits() missing parameter #59

leiyue1989 opened this issue Aug 26, 2020 · 3 comments

Comments

@leiyue1989
Copy link

param
I want the commit under the branch of this project, but this method does not have a second argument

What am I supposed to do ?

@edison-moreland
Copy link

I can't find this function. Could you link the file you found it in?

@edison-moreland
Copy link

Okay, I found it in the v1 branch.

It looks like the refname param was just never added and the whole function disappeared with v2. Thankfully, it should be really easy to add. I'll start adding this now on my fork.

@edison-moreland
Copy link

I've added RefName to the CommitOptions object so that you can use the ProjectCommits function.
Here is my change: https://github.com/edison-moreland/go-gitlab-client/blob/v3/gitlab/commits.go#L97

You'll need to switch to the v3 branch of my fork.

Let me know if you have any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants