Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all the ticks to the renderTick function #2211

Closed
liqwid opened this issue Jan 6, 2023 · 1 comment
Closed

Pass all the ticks to the renderTick function #2211

liqwid opened this issue Jan 6, 2023 · 1 comment

Comments

@liqwid
Copy link

liqwid commented Jan 6, 2023

Is your feature request related to a problem? Please describe.
It's currently impossible to understand the magnitude of all the ticks when rendering a particular one.

E.g. depending on the whole ticks set we want to render:
500, 1000, 1500, 2000 as 0.5K, 1K, 1.5K, 2K
and
100, 200, 300, 400, 500 as 100, 200, 300, 400, 500

Describe the solution you'd like
Adding all the ticks to the renderTick callback will allow to easily understand the magnitude and also is a really simple change

Describe alternatives you've considered
We can understand ticks magnitude from the max data value but it's less of a universal solution, since data formats differ and results in extra calculations

@stale stale bot added the stale label Apr 7, 2023
Repository owner deleted a comment from stale bot Apr 10, 2023
@plouc
Copy link
Owner

plouc commented Apr 10, 2023

It might seem like a simple change, but it's not, the default tick component is memoized, and ticks can be animated, passing all ticks could invalidate the a single tick even if only others changed.

@stale stale bot removed the stale label Apr 10, 2023
@plouc plouc closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants