Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background nodes appear wrong after round-tripping "leavesOnly" #56

Closed
edbrannin opened this issue Sep 18, 2017 · 1 comment
Closed

Comments

@edbrannin
Copy link

Steps to reproduce:

  1. Go to http://nivo.rocks/#/treemap
  2. Click on the leavesOnly toggle.
  3. Click on the leavesOnly toggle again.
  4. (Bonus) Roll The Dice

Expected result:

  • The treemap changes somehow, then changes back to how it looked before.
  • Changing source data looks fine

Observed results:

  1. Load page:
    image
  2. Leaves Only, On:
    image
  3. Leaves Only, Off:
    image
  4. Roll The Dice:
    image

Also

Leaves Only says

Only render leaf nodes (no children).

Shouldn't that be (no parents)?

@edbrannin edbrannin changed the title Background nodes appear incorrectly "leavesOnly" twice Background nodes appear after round-tripping "leavesOnly" Sep 18, 2017
@edbrannin edbrannin changed the title Background nodes appear after round-tripping "leavesOnly" Background nodes appear wrong after round-tripping "leavesOnly" Sep 18, 2017
@plouc
Copy link
Owner

plouc commented Sep 19, 2017

fixed

@plouc plouc closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants