tickCount not working

[brandonchoe]

I am unable to get tickCount to work (mentioned in #57). tickValues does work, but tickCount doesn't do anything. I am using nivo@0.29.4.

[plouc]

Can you provide more context please? If you look at this example, you can see it working.

[plouc]

@brandonchoe I close this issue as it works on the provided example and I got no feedback from you, let me know if you still experience issue with this and can provide context.

[mjsarfatti]

I would like to re-open the issue because tickCount is still not working.
in nivo/packages/core/src/lib/cartesian/axes.js, line 81-82 we have:

   const tickValues = isArray(_tickValues) ? _tickValues : undefined
   const tickCount = isNumber(_tickValues) ? _tickValues : undefined

Which means that the property tickCount is ignored, but if the property tickValues is a number instead of an array, it will be treated as tickCount.

Eg. setting tickValues: 2 will draw only the '0' and the highest tick value.

[plouc]

tickCount has been removed in favor of a more versatile tickValues, to avoid having several properties to handle the same functionality, it works as described here.

[plouc]

See d3/d3-array#61 for tick count.

[mjsarfatti]

Right, somehow I had missed that, sorry!

[plouc]

No problem, it changed recently :)