Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatterplot TimeScale min/max not working when using non-native dates #675

Closed
rgiese opened this issue Aug 25, 2019 · 4 comments
Closed
Labels

Comments

@rgiese
Copy link

rgiese commented Aug 25, 2019

I'd expect the scatter plot's timescale to honor the min/max parameters when I'm using a non-native date format. It looks like it's just a typo in the code:

    let minValue = min
    if (min === 'auto') {
        minValue = values.min
    } else if (format !== 'native') {
        minValue = normalize(values.min)
    }

I suspect that should be:

    let minValue = min
    if (min === 'auto') {
        minValue = values.min
    } else if (format !== 'native') {
        minValue = normalize(min) // <---
    }

Same for max.

Also, while we're at it, the properties min, max, and useUTC are missing from the TypeScript definition for this.

@chandru89new
Copy link

Running into this same issue when trying to set a min value for a time-based ScatterPlot. @rgiese did you find any workaround for this?

@rgiese
Copy link
Author

rgiese commented May 28, 2020

@chandru89new I did not, I just left it unset since that was close enough for what I was trying to do. If it matters more to you, I suspect this should be an easy PR to get through.

@stale
Copy link

stale bot commented Oct 29, 2020

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 29, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants