Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

Should treat URLs as atoms when splitting long chat messages #143

Closed
mortenn opened this issue Oct 11, 2017 · 5 comments
Closed

Should treat URLs as atoms when splitting long chat messages #143

mortenn opened this issue Oct 11, 2017 · 5 comments

Comments

@mortenn
Copy link
Contributor

mortenn commented Oct 11, 2017

Sometimes, a bot chat message is too long so it gets split up.
This is a nice feature, but it can corrupt links.

It would be very much appreciated if the string splitter did some basic parsing to avoid this happening.

@mortenn
Copy link
Contributor Author

mortenn commented Oct 11, 2017

Splits can also occur in the middle of a multibyte char, munging things like japanese and korean.

@mortenn
Copy link
Contributor Author

mortenn commented Oct 11, 2017

Example image

@thedark1337
Copy link
Member

thedark1337 commented Oct 11, 2017

Have been planning to use https://www.npmjs.com/package/plug-message-split
for this exact purpose but haven't had time (Either by adapting the code, or adding it in as a dep)

@mortenn
Copy link
Contributor Author

mortenn commented Oct 17, 2017

In the interim, I added that module to my own code. Was happy to see it has no deps :)

@thedark1337
Copy link
Member

v5.1.0 has added this. Thanks @goto-bus-stop for creating plug-message-split <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants