Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

The advance event when last DJ finishes has djs.length == 2 #145

Closed
mortenn opened this issue Oct 16, 2017 · 2 comments
Closed

The advance event when last DJ finishes has djs.length == 2 #145

mortenn opened this issue Oct 16, 2017 · 2 comments
Labels
bug in progress

Comments

@mortenn
Copy link
Contributor

mortenn commented Oct 16, 2017

I've seen this over a long period of time. Not sure what djs contain, but I turned on some logging so I can get a dump of the property once it happens again.
@mortenn
Copy link
Contributor Author

mortenn commented Oct 16, 2017

Got it; the djs array contains the bot's user object twice.

@thedark1337
Copy link
Member

I see the issue. Its with room.usersToArray and room.getUser. When having an empty waitlist / no DJ it will have a null currentDJ and that triggers getUser to call getSelf. Will look into a workaround with that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mortenn @thedark1337