New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisite incompatibilities #9
Comments
I can confirm the problem. "Na data available" showing for days after being network-activated. After activating per site it shows data. |
Confirmed from memory. We should add this piece of info to the readme, preferably in FAQ. |
Even better: We fix it :) |
I know it is not long ago, but: Did you fix it already? ;-) https://github.com/pluginkollektiv/statify/blob/master/inc/statify_install.class.php#L27 |
Okay, I tried a fix, but don't ask me what it's about 😆 I changed the install method https://github.com/pluginkollektiv/statify/blob/master/inc/statify_install.class.php#L32
I removed the return when the plugin is not active for network and instead wrapped it with the if statement. The fix might have the side effect that the original purpose of activating the plugin for new blogs might not work now... @sergejmueller Maybe this helps you a tiny bit with fixing it 😉 |
@te-online Multisite plugin activation is quite difficult from normal plugin activation, with lots of edge-cases. I hope this is the solution and will check out your proposed fix. |
@swissspidy To be honest, I think there is a high chance that this is not the correct solution. I didn't fully understand what the first part is used for and when it gets called. I didn't do debugging, just some quick guessing. I only treated the symptom, but not the source of the problem, so to say. Chances are, that maybe $id is not empty at all but is supposed to be. Or maybe the order of the code is just wrong. Maybe this if(empty($id)) {} statement should be placed after the activation code for network-wide, so the return won't cancel the function too early. |
I had the same problem. Having installed Multisite and Statify, Statify did show "No data available". The problem existed independantly from the widget configuration. Apparently there are incompatibilities between both plugins. I fixed it with the help of a wordpress expert. He found out that Statify did not create a data base table in phpMyAdmin because of Multisite. So we created the data base table wp_statify manually, he sent it to me via email and I imported it into phpMyAdmin. Finally, Statify started showing results. Unfortunately, the solution did not work for my second domain which I manage with Multisite, although I added the data base table wp_statify to my second data base on my web server. Does anybody have an explanation for what reason Statify does not work for my second domain? May it be related to Domain Mapping? Thanks in advance for some clues! |
@Berlinicker Thanks for chiming in. This ticket is all about multisite incompatibilities and the missing database tables. I hope to find some time this spring to work on it. Out of the blue I can't say anything about your second website. Have you added only 1 table or 1 for every blog? (Not sure what Statify requires at the moment). Domain mapping could be a culprit here, but I'd need to test it. |
@Berlinicker Are you sure, you've got the prefixes right? Maybe you have set up a different prefix for this installation than |
@swissspidy and @te-online Thanks for the quick responses. It is great that you are going to fix the problem. In fact, I have added only one table to the main data base which corresponds to my wp-config.php. My second data base seems to be for something else than my second domain, so adding the table to the second data base did not change anything. Should I add another table to the main data base which corresponds to my wp-config.php? Which prefix do I have to use in that case? Thanks in advance! |
@Berlinicker As far as I know, with multisite, you should have a db structure like this:
To be clear, all the tables are in one database with multisite per default. WordPress can only access databases, that are specified in wp-config.php. Considering this, you would need a statify table for each of your multisite sites.
|
@te-online That's it! Now it works. Thanks a lot for your help! Thanks to WordPress expert Finn Dohrn from bit01, too! http://www.bit01.de/. That was a remarkable service! |
Is there an ETA on a Plugin Version that handels this issue? Or a HowTo Article how to achive statify working on Multisite? |
@huberfe Thanks for asking. As I said in January, I was hoping to have some time this spring to fix this issue. Spring is now, so give me a few weeks to look into this, i.e. until end of May. If anyone's able to help earlier, feel free to jump in and submit a PR. |
merci dir |
@swissspidy Any news on this? |
@Zodiac1978 Sorry, no update means no progress. But since you asked, I finally took an hour to look at it. #23 should fix this. Perhaps need to adjust version numbers in the inline docs though :) As I'm normally not using Statify, someone else needs to test and merge this. Thanks. |
Just tested on a multisite installation and it worked! Thank you for fixing it. |
I think #23 only fixes parts of the multisite issues. The one with the permalinks mentioned in the issue description is still unfixed IIRC. |
That should be a quick fix, since it's only the output rendering, right? Maybe I can look into that later. Edit: Actually, that seems to be fixed. On my test installation it works as expected. (You're talking about that one, are you? https://wordpress.org/support/topic/links-missing-subfolder-on-multisite?replies=9#post-7074398) |
Yes, I'm talking about that one. Apparently I already fixed it last year, see c720623 😄 Therefore closing this issue. |
Just for completeness: And you can workaround the activation issue if you activate the plugin on each site separately. |
@Zodiac1978 No need for that workaround anymore as this bug should be fixed after merging #23. Edit: Or am I missing something? |
That's why I wrote "just for completeness" - I just wanted to mention this workaround here. In case someone is stuck on an old version and might want to know it. ;) |
As I'm activating the plugin on a MultiSite with > 1500 sites the tables are not created. Until now I was not able to figure out why not and as soon as I activate it for a single site in the network, the wp_X_statify table is perfectly added to the DB. |
@ouun Did you check you server logs, whether you might be running into a timeout with switching to 1500 blogs and running a single Looking forward to your report 😉 |
I just tried activating the plugin network-wide. Even after I had visited each site's dashboard, no database tables were created.
Not sure if it's my fault or there's something wrong in the plugin, but it may be worth exploring. Other users reported multisite incompatibilities as well:
https://wordpress.org/support/topic/links-missing-subfolder-on-multisite?replies=9#post-7074398
The text was updated successfully, but these errors were encountered: