-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support URLs containing slashes #6
Comments
This looks great. I was kind of hoping that this 'prefix' feature would be added to the UID field type directly. Nonetheless this adds a lot of value to the plugin. I'll test it out. Could you create a PR? |
Agreed it would be more useful to allow this in UID field. I've put up a PR, feel free to amend as needed. |
I made a couple of changes, most primarily:
See #9 |
Nice job, thanks for fixing. The only issue I see with making the area field a UID too is if a URL path needs multiple slashes eg |
That should not be an issue anymore because I've altered the regex of the UID field to allow slashes. |
Fixed in v1.1.2 (https://github.com/boazpoolman/strapi-plugin-sitemap/releases/tag/1.1.2) |
Currently the plugin assumes that all Strapi pages are at the root of the site. URLs like
https://my-site.com/articles/my-strapi-article-1
are not supported because the UID field used in the sitemap doesn't allow slashes. Custom entries have the same problem. I had a go at a solution here that adds anarea
property to the settings for both custom and collection entries. Let me know what you think.The text was updated successfully, but these errors were encountered: