PHP warnings (related to validation feature ?)

[dethegeek]

While setting up a form I see 2 warnings in debug mode. Here are the backtraces :

2014-10-16 15:06:09
Notice(8): Undefined index: validation_required
Backtrace :
/glpi/inc/toolbox.class.php:531 Toolbox::userErrorHandlerNormal()
/glpi/plugins/formcreator/inc/form.class.php:319 Toolbox::userErrorHandlerDebug()
/glpi/plugins/formcreator/front/form.form.php:77 PluginFormcreatorForm->showForm()

2014-10-16 15:06:09
Notice(8): Undefined index: validation_required
Backtrace :
/glpi/inc/toolbox.class.php:531 Toolbox::userErrorHandlerNormal()
/glpi/plugins/formcreator/inc/form.class.php:363 Toolbox::userErrorHandlerDebug()
/glpi/plugins/formcreator/front/form.form.php:77 PluginFormcreatorForm->showForm()

[dethegeek]

I'm reviewing the code and I think the issue is related to the upgrade from the first release.

The table glpi_plugin_formcreator_forms does not have the column "validation_required".

The plugin should increment its version and update the tables upon upgrade.

[neeftarah]

The code was here... But the condition was wrong. Thank's for this issue.

For fixing it without reinstall the plugin just run the SQL command:
"ALTER TABLE glpi_plugin_formcreator_forms ADD validation_required tinyint(1) NOT NULL DEFAULT '0';"

The correction will included in next tag.