Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Custom published port for nginx #51

Open
biblia19 opened this issue Nov 14, 2023 · 2 comments
Open

[Feature] Custom published port for nginx #51

biblia19 opened this issue Nov 14, 2023 · 2 comments

Comments

@biblia19
Copy link

Description of the feature you are requesting:
User can easily to change published port with .env file
Maybe duplicate with [Feature] Specify ports for all services in the .env file

Describe the solution you'd like

.env

...
# Bottom of the file
# Custom Port Configuration
NGINX_PORT=18082 # (or whatever you want)

docker-compose.yml

version: "3.9"

services:
...
  nginx:
    ...
    ports:
      - ${NGINX_PORT:-8082}:80

Additional context
User can check the port with docker compose config | grep published

@pluja
Copy link
Owner

pluja commented Nov 21, 2023

Is there any particular reason why you prefer doing it from the .env rather than the compose.yml itself?

@biblia19
Copy link
Author

Nothing special, but I think that users as possible only change the environment variable in .env without change docker-compose.yml. Because when developer tracked the bug from other users, you need to read all user-custom docker-compose.yml everytime. And I want to change the nginx port easily without read all docker-compose.yml.
Or I just refer other repository like [mattermost/docker] env.example

If you do not want to plan these feature, just close the issue please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants