Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comment on encode_pt() #17

Closed
0xbok opened this issue May 8, 2023 · 0 comments · Fixed by #46
Closed

Incorrect comment on encode_pt() #17

0xbok opened this issue May 8, 2023 · 0 comments · Fixed by #46

Comments

@0xbok
Copy link

0xbok commented May 8, 2023

https://github.com/plume-sig/zk-nullifier-sig/blob/main/rust-k256/src/lib.rs#L429-L435

encode_pt() is described as:

/// Format a ProjectivePoint to 64 bytes - the concatenation of the x and y values.  We use 64
/// bytes instead of SEC1 encoding as our arkworks secp256k1 implementation doesn't support SEC1
/// encoding yet.

However, it converts a ProjectivePoint to its compressed form of 33 bytes.

@Divide-By-0 Divide-By-0 linked a pull request Sep 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant