Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix http status error response for 403 Forbidden and 401 Unauthorized #1014

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

almontasser
Copy link
Contributor

The error 401 should be returned to non authenticated users, and 403 should be return to authenticated users who are not authorized to access the resource.

@ktutnik ktutnik changed the title Bug Fix: Proper authentication and authorization errors fix: Fix http status error response for 403 Forbidden and 401 Unauthorized Sep 2, 2021
@ktutnik
Copy link
Collaborator

ktutnik commented Sep 2, 2021

I admit that I was confused about the 401 and 403, and you are right https://stackoverflow.com/a/57376260/212706

Thank you for your contribution.

PS: I should edit the subject to match the conventional commit message https://www.conventionalcommits.org/en/v1.0.0/

@ktutnik ktutnik changed the title fix: Fix http status error response for 403 Forbidden and 401 Unauthorized fix(core): Fix http status error response for 403 Forbidden and 401 Unauthorized Sep 2, 2021
@ktutnik
Copy link
Collaborator

ktutnik commented Sep 2, 2021

@almontasser I fixed the dependency issue causing the error tests, it should be on the master branch now.

Can you sync your fork and update the PR?

@ktutnik ktutnik merged commit b235819 into plumier:master Sep 2, 2021
@ktutnik
Copy link
Collaborator

ktutnik commented Sep 2, 2021

@almontasser please ignore, i can update the PR myself. Its merged already thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants