Skip to content

Commit

Permalink
fix(emptystate): set should not update after unmounting component
Browse files Browse the repository at this point in the history
There was an issue where state was being updated if the component was quickly mounted and unmounted.
This change will not update state if the component has been unmounted. also I converted to react
hooks and used an effect closure to make it easier to reason about

BREAKING CHANGE: react version upgrade
  • Loading branch information
danethurber committed May 15, 2019
1 parent 4523471 commit b625087
Show file tree
Hide file tree
Showing 9 changed files with 748 additions and 779 deletions.
2 changes: 1 addition & 1 deletion packages/emptystate/package.json
Expand Up @@ -33,7 +33,7 @@
"peerDependencies": {
"@pluralsight/ps-design-system-normalize": "*",
"glamor": "^2.x.x",
"react": ">=16.3.0 < 17.0.0"
"react": ">=16.8.6 < 17.0.0"
},
"devDependencies": {
"@pluralsight/ps-design-system-build": "*",
Expand Down

0 comments on commit b625087

Please sign in to comment.