feat: button link ts conversion #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamic type, overload on clone need to figure out
need to pull in link stuff
…at/link-button-ts-conversion
…at/link-button-ts-conversion # Conflicts: # packages/button/package.json # packages/link/package.json
danethurber
approved these changes
Oct 5, 2020
| delete filteredProps.onClick | ||
| } | ||
|
|
||
| return React.createElement( |
There was a problem hiding this comment.
i wonder why we were using createElement....guessing this was one of the first components and maybe we didn't support jsx then. just thinking out load - don't change anything for this pr but i might follow up with a conversion to jsx...
packages/button/src/react/index.tsx
Outdated
Comment on lines
211
to
221
| Button.propTypes = { | ||
| appearance: PropTypes.oneOf(Object.keys(vars.appearances)), | ||
| children: PropTypes.any, | ||
| disabled: PropTypes.bool, | ||
| href: PropTypes.string, | ||
| icon: PropTypes.element, | ||
| iconAlign: PropTypes.oneOf(Object.keys(vars.iconAligns)), | ||
| loading: PropTypes.bool, | ||
| size: PropTypes.oneOf(Object.keys(vars.sizes)), | ||
| style: PropTypes.object | ||
| } |
There was a problem hiding this comment.
Suggested change
| Button.propTypes = { | |
| appearance: PropTypes.oneOf(Object.keys(vars.appearances)), | |
| children: PropTypes.any, | |
| disabled: PropTypes.bool, | |
| href: PropTypes.string, | |
| icon: PropTypes.element, | |
| iconAlign: PropTypes.oneOf(Object.keys(vars.iconAligns)), | |
| loading: PropTypes.bool, | |
| size: PropTypes.oneOf(Object.keys(vars.sizes)), | |
| style: PropTypes.object | |
| } | |
| Button.propTypes = { | |
| appearance: PropTypes.oneOf(Object.keys(vars.appearances)), | |
| children: PropTypes.any, | |
| disabled: PropTypes.bool, | |
| href: PropTypes.string, | |
| icon: PropTypes.element, | |
| iconAlign: PropTypes.oneOf(Object.keys(vars.iconAligns)), | |
| loading: PropTypes.bool, | |
| size: PropTypes.oneOf(Object.keys(vars.sizes)), | |
| style: PropTypes.object | |
| } |
There was a problem hiding this comment.
i don't think we need to add proptypes anymore. if we want to support this in the future we should generate them from the ts typings
danethurber
added a commit
that referenced
this pull request
Oct 7, 2020
…to ts/verttabs * 'ts/verttabs' of github.com:pluralsight/design-system: (33 commits) build: fix secvulns by forcing package resolution refactor(docs): use postcss-env to declare media vars refactor(datepicker): update related snapshots feat(docs): linked headings in mdx fix(docs): single line commits to fix transform in preview fix(docs): properly label dev workflow lang types fix(docs): rm shell-session from supported renderable langs fix(docs): rm slack in the props, lol refactor(docs): give side nav custom scroller feat(docs): add css ssr plugins feat(docs): supply deps to new codesandboxes refactor(datepicker): adjust min-width feat: button link ts conversion (#1280) refactor(badge): use keymirror in vars test(badge): rm js snapshot build(badge): correct build scripts for ts refactor(badge): remove index.js refs refactor(badge): rm filterReactProps build(badge): cp verticaltabs latest tsconfig.json build(badge): mv index.js to index.ts ...
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ts conversion link and button