Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textinput: needs to support title attribute #276

Closed
KaidenR opened this issue Oct 11, 2018 · 2 comments · Fixed by #291
Closed

textinput: needs to support title attribute #276

KaidenR opened this issue Oct 11, 2018 · 2 comments · Fixed by #291
Assignees
@danethurber
Labels
bug Something isn't working
Projects
Work

Comments

@KaidenR
Copy link
Contributor

KaidenR commented Oct 11, 2018 •
edited

Bug

Expected behavior

Needs to support adding a "title" attribute for accessibility

Actual behavior

Title attribute is not a whitelisted prop

Additional thoughts

Might be a good idea to whitelist title across the board for all components that have display elements.
@KaidenR KaidenR added the bug Something isn't working label Oct 11, 2018
@danethurber danethurber added this to TODO in Work Oct 15, 2018
@jaketrent
Copy link
Contributor

Triage: will address single TextInput component for now.

@jaketrent jaketrent moved this from Not Prioritized to Prioritized in Work Oct 16, 2018
@jaketrent
Copy link
Contributor

jaketrent commented Oct 16, 2018 •
edited

Triage: talk about #162 and #163 when we visit this.

@danethurber danethurber moved this from Prioritized to In Progress in Work Oct 18, 2018
danethurber added a commit that referenced this issue Oct 18, 2018
@danethurber
fix(textinput): whilelist title prop
a72ebd3 
fix #276
@danethurber danethurber mentioned this issue Oct 18, 2018
Merged
@danethurber danethurber self-assigned this Oct 18, 2018
Work automation moved this from In Progress to Done Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danethurber danethurber

Labels
bug Something isn't working
Projects
Work
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(textinput): whilelist title prop pluralsight/classic-design-system
3 participants
@danethurber @jaketrent @KaidenR