util typescript #1328

danethurber · 2020-10-12T17:04:15Z

all the typescript!

packages/util/src/create-universal-portal.ts

jaketrent

after root yarn && yarn build,

tsc giving me:

On the first error, rename to storyshots.spec.ts, and should resolve.

design-system/packages/util on  refactor/util-ts [$!] ❯ tsc
src/__specs__/storyshots.spec.tsx:11:31 - error TS2345: Argument of type '{ createNodeMock: () => HTMLDivElement; }' is not assignable to parameter of type 'Function | { renderer?: any; serializer?: any; }'.
  Object literal may only specify known properties, and 'createNodeMock' does not exist in type 'Function | { renderer?: any; serializer?: any; }'.

11   test: snapshotWithOptions({ createNodeMock })
                                 ~~~~~~~~~~~~~~

src/__specs__/use-combined-refs.spec.tsx:13:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

13       useImperativeHandle(combinedRef, () => ({
                                                ~~
14         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
15       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.

src/__specs__/use-combined-refs.spec.tsx:26:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

26       useImperativeHandle(combinedRef, () => ({
                                                ~~
27         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
28       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.

src/__specs__/use-combined-refs.spec.tsx:39:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

39       useImperativeHandle(combinedRef, () => ({
                                                ~~
40         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
41       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.


Found 4 errors.

.eslintignore

packages/util/src/__specs__/combine-fns.spec.ts

packages/util/src/combine-fns.ts

jaketrent · 2020-10-13T19:32:33Z

Dane, not sure if you're planning to do more on this. Are you getting the same 4 tsc errors that I was? Do you plan to address them in new commits?

danethurber · 2020-10-13T19:35:40Z

I'll look and see about the errors. I wasn't getting them when I built but I can def try again

…em into refactor/util-ts * 'refactor/util-ts' of github.com:pluralsight/design-system: refactor(docs): adjust max-width of main refactor(docs): rename vars for clarity fix(docs): restore the scroll restore, broken by scrollable feat(docs): persist sidenav group toggling feat(docs): open sidenav group containing active link feat(docs): highlight active sidenav link fix(docs): make heading more specific for unreliable style order fix(docs): hack search thin enough to mostly fit and not disturb scrollbar fix(docs): horz align scrollbar on sidenav refactor(docs): adjust color of fade to match editor background color refactor(docs): spacing page - move toc below heading

* master: fix(docs): ssr and sessionstorage build: publish build: publish build: publish build: commit lock refactor(halo): make props to styles required build(halo): tsc strict build(halo): return to storyshots.spec.tsx and cleanup test(halo): rename storyshots file for ts refactor(halo): fully convert to typescript refactor(halo): move to ts build refactor(halo): move to ts files Feat/linerprogress ts conversion (#1332) refactor(prop-types): change method of determining NODE_ENV to be compat with webpack5

jaketrent

I still get these errors:

design-system/packages/util on  refactor/util-ts [⇣$!] ❯ tsc --version
Version 4.0.2
design-system/packages/util on  refactor/util-ts [⇣$!] ❯ tsc
src/__specs__/storyshots.spec.tsx:11:31 - error TS2345: Argument of type '{ createNodeMock: () => HTMLDivElement; }' is not assignable to parameter of type 'Function | { renderer?: any; serializer?: any; }'.
  Object literal may only specify known properties, and 'createNodeMock' does not exist in type 'Function | { renderer?: any; serializer?: any; }'.

11   test: snapshotWithOptions({ createNodeMock })
                                 ~~~~~~~~~~~~~~

src/__specs__/use-combined-refs.spec.tsx:13:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

13       useImperativeHandle(combinedRef, () => ({
                                                ~~
14         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
15       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.

src/__specs__/use-combined-refs.spec.tsx:26:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

26       useImperativeHandle(combinedRef, () => ({
                                                ~~
27         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
28       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.

src/__specs__/use-combined-refs.spec.tsx:39:46 - error TS2322: Type '{ value: string; }' is not assignable to type 'undefined'.

39       useImperativeHandle(combinedRef, () => ({
                                                ~~
40         value: 'ref'
   ~~~~~~~~~~~~~~~~~~~~
41       }))
   ~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:1093:79
    1093     function useImperativeHandle<T, R extends T>(ref: Ref<T>|undefined, init: () => R, deps?: DependencyList): void;
                                                                                       ~~~~~~~
    The expected type comes from the return type of this signature.


Found 4 errors.

jaketrent · 2020-10-15T19:18:57Z

packages/actionmenu/src/react/index.tsx

-    const fallbackRef = React.useRef()
-    const ref = forwardedRef || fallbackRef
+    const ref = React.useRef<HTMLUListElement>()
+    useImperativeHandle(forwardedRef, () => ref.current)


Not null problem for you like mine, eh? 🤷

jaketrent

tsc local is clean for me now!

* master: build(deps): bump object-path from 0.11.4 to 0.11.5 build: publish fix(util): drop storybook dep to fix circle dep ci: force workspaces ci: ignore ts dist files test(tag): update because of icon changes test(card): update because of icon change refactor(icon): convert to typescript

danethurber added 6 commits October 12, 2020 09:06

refactor(util): move to ts files

32cf0b0

refactor(util): convert a few files to ts

7e20cef

ci: lint ignore dist ts

da359df

fix(util): bad import path

324159e

style(verticaltabs): update typing signature

04d8367

fix(util): call canUseDom in portal creation fn

b57e56a

danethurber changed the title ~~[WIP] refactor(util): move to ts files~~ util typescript Oct 13, 2020

danethurber marked this pull request as ready for review October 13, 2020 13:59

Merge branch 'master' into refactor/util-ts

3faaa9a

jaketrent reviewed Oct 13, 2020

View reviewed changes

packages/util/src/create-universal-portal.ts Outdated Show resolved Hide resolved

jaketrent reviewed Oct 13, 2020

View reviewed changes

.eslintignore Outdated Show resolved Hide resolved

packages/util/src/__specs__/combine-fns.spec.ts Show resolved Hide resolved

packages/util/src/combine-fns.ts Show resolved Hide resolved

danethurber added 11 commits October 14, 2020 09:06

test(util): also tsc when testing

a5c10ad

test(util): fix ts error in snapshot config

784ce4c

feat(util): deprecate prop-type utils

9899684

fix(util): update ref typings

811ee18

feat(actionmenu): update failing ref typings

8285652

feat(dropdown): update failing ref typings

51703f8

refactor(util): strict type ref hooks

1cb1946

refactor(util): strict type menu keys

96b7176

refactor(util): strict ts

084dd98

danethurber requested a review from jaketrent October 14, 2020 21:32

jaketrent suggested changes Oct 15, 2020

View reviewed changes

danethurber added 2 commits October 19, 2020 08:18

Merge branch 'master' into refactor/util-ts

9c44d39

style(radio): fix util typing

c0eb3e6

danethurber requested a review from jaketrent October 19, 2020 14:52

jaketrent approved these changes Oct 20, 2020

View reviewed changes

danethurber merged commit 7c942d7 into master Oct 20, 2020

danethurber deleted the refactor/util-ts branch October 20, 2020 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util typescript #1328

util typescript #1328

danethurber commented Oct 12, 2020

jaketrent left a comment •

edited

jaketrent commented Oct 13, 2020

danethurber commented Oct 13, 2020

jaketrent left a comment

jaketrent Oct 15, 2020

jaketrent left a comment

util typescript #1328

util typescript #1328

Conversation

danethurber commented Oct 12, 2020

jaketrent left a comment • edited

Choose a reason for hiding this comment

jaketrent commented Oct 13, 2020

danethurber commented Oct 13, 2020

jaketrent left a comment

Choose a reason for hiding this comment

jaketrent Oct 15, 2020

Choose a reason for hiding this comment

jaketrent left a comment

Choose a reason for hiding this comment

jaketrent left a comment •

edited