Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error or warning is raised when required input files are missing #1

Open
luukvdmeer opened this issue Feb 16, 2023 · 1 comment
Open

Comments

@luukvdmeer
Copy link
Member

For example: When I compute netascore (Docker + OSM workflow) using a weight file that specifies a non-zero weight for gradient_bicycle, but do not provide a DEM, the computation succeeds without giving any error or warning. The same is true for specifying a noise weight without providing a noise file.

How are these situations handled internally? Does it mess up the normalization of the indices? Depending on that, I would at least give a warning but probably better an error.

@christian-werner
Copy link
Member

@luukvdmeer Index calculation will not be messed up - the indicator will be ignored (as if weight = NULL). However, I totally agree that we should output a warning in such cases.

After discussion with @robin-wendel we propose the following solution:
In index step, for every indicator we check whether all indicator values are NULL and in this case issue a warning (loglevel=1 / major info). Furthermore, we plan to generally include a quality indicator. This indicator would also be reduced by the weight that is assigned to the missing indicator.
This solution would work for any missing indicator and should also catch cases of e.g. a DEM provided but spatially not intersecting the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants