Scope SavedStateFlowHandle to ViewModel's, create assisted injection extension functions, & add CI to run unit tests and build #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateFlowHandle to the hilt ViewModelScope
plusmobileapps
commented
Jan 7, 2022
sample/hilt-di/src/main/java/com/plusmobileapps/savedstateflow/Modules.kt
Show resolved
Hide resolved
plusmobileapps
commented
Jan 7, 2022
plusmobileapps
commented
Jan 7, 2022
|
Can we add tests for the injection? Would it make sense? |
|
@KaustubhPatange I was thinking about adding tests for this injection, although since Hilt is a compile time safety dependency injection framework and not runtime. I was thinking the compilation of the hilt sample would be sufficient enough as a test? Otherwise if we feel the need to test, is this possible to cover in a unit test or write an espresso test for the sample perhaps? |
plusmobileapps
changed the title
plusmobileapps
changed the title
plusmobileapps
force-pushed
the
savedstateflow-hilt
branch
from
7d276aa
to
a0a73fe
Compare
|
Through the unit test, it is not possible. But I get your point a sample app if compiled through CI is more than enough to see if the injection works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #10
In order to get the CI to work and build the whole project, needed to rename the packages of each sample to not conflict with the library.