-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crashadapter-leak) : Clear reference of crashAdapter after fragment is destroyed #233
Conversation
…hed at least the INITIALIZED state.
To do this, I have modified the FragmentViewBindingDelegate class to accomodate all types of variables and not just binding.
looks good to me, can you also explore if we can keep definition & declaration together (not mandatory though) |
What do you think about this approach? @srtvprateek |
nice 🔥 |
… after the fragment is destroyed
Made the changes! |
@Piyush7890 run |
@srtvprateek my bad. Tasks ran successfully |
Clear adapter reference once the fragment is destroyed.
To do this, I have modified the FragmentViewBindingDelegate class to accommodate all types of variables and not just binding.
Fixes #207
Let me know If I should continue working on this PR, basically modify all the adapters to use 'autoCleared'