Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap and Unwrap are depricated in v8 #50

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 1 comment
Closed

Wrap and Unwrap are depricated in v8 #50

GoogleCodeExporter opened this issue Mar 14, 2015 · 1 comment
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 


Wrap and Unwrap are depricated in v8. It is recommended to use New, Cast and 
Value instead.

Included is a quick fix that worked with the newest v8, But I'm not a c/c++ 
coder so someone look through it. 

Made with Antti Jokipii.

Original issue reported on code.google.com by jukka.ra...@gmail.com on 31 Jan 2013 at 3:35

Attachments:
@GoogleCodeExporter
Copy link
Author 

Applied.  Modified a little mainly because I saw the regression failure around 
Cast()->Value().  It seems GetPointerFromInternalField() takes place more 
gracefully.  Thanks for the patch and report!

Original comment by umi.tan...@gmail.com on 20 Feb 2013 at 8:00

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter