Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric names should change "." to "_" #21

Closed
rgordill opened this issue Sep 13, 2023 · 2 comments · Fixed by #22
Closed

Metric names should change "." to "_" #21

rgordill opened this issue Sep 13, 2023 · 2 comments · Fixed by #22

Comments

@rgordill
Copy link
Contributor

There are some warnings regarding prometheus metric name compliance (https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels):

time="2023-09-13T17:18:01Z" level=warning msg="Metric name should only include ASCII letters, numbers and underscores. This name will stop working in k6 v0.48.0 (around December 2023)." name=mqtt.sent.messages.count

@pmalhaire
Copy link
Owner

Thank you for the MR. It's a breaking change existing usage will be impacted. I have to choose if I make it the default and drop the old name or make it optionnal.

@rgordill
Copy link
Contributor Author

As the log says, the metrics with "." will stop working around december this year, so I guess there is little value in keeping them for just three more months. Anyway, we need the "_" for the prometheus metrics,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants