Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imports not being used by library #207

Open
MarkPieszak opened this issue Oct 25, 2021 · 1 comment
Open

imports not being used by library #207

MarkPieszak opened this issue Oct 25, 2021 · 1 comment

Comments

@MarkPieszak
Copy link

Hey team! 👋

It looks like we're not using options.imports and passing them further down into forRoot and forRootAsync (potentially other places?)

https://github.com/pmb0/nestjs-unleash/blob/master/src/unleash/unleash.module.ts#L100

image

I believe we need something as simple as [ ...options.imports ].

Just wanted to create an issue to get the conversation started!
@pmb0
Copy link
Owner

pmb0 commented Dec 13, 2021

Hello, thank you for reporting. I think you are right. Could you submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmb0 @MarkPieszak