JSLint + Bug Fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug where if you type a title that gets converted to a slug (using default settings), and then modify the slug and then tab out. if you're using default settings all your dashes will be removed. I added to the map "2d":"-" which will replace dashes with dashes which works well for if your editing the title and also if you're editing the slug
|
Thank you! Nice work and I especially appreciate the detail in your pull request. Note to self: add unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where if you type a title that gets converted to a slug
(using default settings), and then modify the slug and then tab out. if
you're using default settings all your dashes will be removed. I added
to the map "2d":"-" which will replace dashes with dashes which works
well for if your editing the title and also if you're editing the slug