Global rule management is saved even if cancelled

[phoenix384]

Go to Window - Preferences - PMD - Rule Configuration and activate 'Use global rule management'.
Press 'Cancel'. The activation of 'Use global rule management' is saved anyway.

Expected behaviour would be:
The activation of 'Use global rule management' is only saved when clicking 'Apply'.

[adangel]

Indeed - the flag is stored as part of the UI state here:

pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/PMDPreferencePage2.java

Line 539 in bf1b2c8

PreferenceUIStore.INSTANCE.globalRuleManagement(globalRuleManagementCheckButton.getSelection());

And saveUIState() is called both for performCancel():

pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/PMDPreferencePage2.java

Lines 500 to 504 in bf1b2c8

	public boolean performCancel() {
	saveUIState();
	return super.performCancel();
	}

and performOk():

pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/ui/preferences/br/PMDPreferencePage2.java

Lines 486 to 497 in bf1b2c8

	public boolean performOk() {
	saveUIState();
	if (isModified()) {
	updateRuleSet();
	rebuildProjects();
	storeActiveRules();
	}
	return super.performOk();
	}

The flag should be store not as part of saveUIState() but in performOk() only.