-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
/
AssignmentToNonFinalStaticRule.java
56 lines (47 loc) · 1.93 KB
/
AssignmentToNonFinalStaticRule.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.rule.errorprone;
import org.checkerframework.checker.nullness.qual.Nullable;
import net.sourceforge.pmd.lang.java.ast.ASTAssignableExpr.ASTNamedReferenceExpr;
import net.sourceforge.pmd.lang.java.ast.ASTAssignableExpr.AccessType;
import net.sourceforge.pmd.lang.java.ast.ASTConstructorDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTFieldAccess;
import net.sourceforge.pmd.lang.java.ast.ASTVariableAccess;
import net.sourceforge.pmd.lang.java.rule.AbstractJavaRulechainRule;
import net.sourceforge.pmd.lang.java.symbols.JFieldSymbol;
import net.sourceforge.pmd.lang.java.symbols.JVariableSymbol;
/**
* @author Eric Olander
* @since Created on October 24, 2004, 8:56 AM
*/
public class AssignmentToNonFinalStaticRule extends AbstractJavaRulechainRule {
public AssignmentToNonFinalStaticRule() {
super(ASTFieldAccess.class, ASTVariableAccess.class);
}
@Override
public Object visit(ASTVariableAccess node, Object data) {
checkAccess(node, data);
return null;
}
@Override
public Object visit(ASTFieldAccess node, Object data) {
checkAccess(node, data);
return null;
}
private void checkAccess(ASTNamedReferenceExpr node, Object data) {
if (isInsideConstructor(node) && node.getAccessType() == AccessType.WRITE) {
@Nullable
JVariableSymbol symbol = node.getReferencedSym();
if (symbol != null && symbol.isField()) {
JFieldSymbol field = (JFieldSymbol) symbol;
if (field.isStatic() && !field.isFinal()) {
asCtx(data).addViolation(node, field.getSimpleName());
}
}
}
}
private boolean isInsideConstructor(ASTNamedReferenceExpr node) {
return node.ancestors(ASTConstructorDeclaration.class).nonEmpty();
}
}