Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apex,vf] Remove CodeClimate dependency #1648

Closed
rsoesemann opened this issue Feb 8, 2019 · 2 comments
Closed

[apex,vf] Remove CodeClimate dependency #1648

rsoesemann opened this issue Feb 8, 2019 · 2 comments
Assignees
Labels
is:feature-removal Remove an unneeded unused feature
Milestone

Comments

@rsoesemann
Copy link
Member

Applies to all rules related to Apex and Visualforce. Back then when I ported PDM to Salesforce CodeClimate was the only platform to integrate with. To make PMD work with them we had to add custom renderers and properties.

Neighter I nor somebody else is using this anymore and it clutters the rule and ruleset code. So I'd suggest we remove this again.

I can provide a PR for that. But I want to hear your opinion on this @jsotuyod @adangel

@adangel adangel added this to the 7.0.0 milestone Feb 13, 2019
@rsoesemann rsoesemann self-assigned this Feb 25, 2019
@rsoesemann rsoesemann added the is:feature-removal Remove an unneeded unused feature label Feb 25, 2019
@adangel
Copy link
Member

adangel commented Feb 25, 2019

Since this is removing a feature, it won't be backwards compatible. We can only remove this with the next major release, which is 7.0.0.

While maybe the code climate renderer is not demanded, there is a request about adding a generic json renderer, see #1286

@rsoesemann
Copy link
Member Author

Hi Andreas, I didn't touch the CodeClimate renderer as it was added by another person and might be of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature-removal Remove an unneeded unused feature
Projects
None yet
Development

No branches or pull requests

2 participants