[java] UselessParentheses false positive with boolean operators

[xuanuy]

Affects PMD Version: 3.12.0

Rule: UselessParentheses

Description:
I have the condition if(a || b || (c & d) || e)
Then I get Useless parentheses violation message.

Code Sample demonstrating the issue:

if(a || b || (c & d) || e) {
 //do sth
}

Running PMD through: Maven

Java JDK 8

[AnthonyKot]

Sounds reasonable:
https://softwareengineering.stackexchange.com/questions/201175/should-i-use-parentheses-in-logical-statements-even-where-not-necessary
I will try to fix it

[AnthonyKot]

#1920

[adangel]

Since & has a higher precedence than ||, the rule correct in saying: The parentheses are not needed. See operator precedence.

However, in terms of readability, it's maybe better to allow these parentheses.
Similar discussion is here: #1673

Maybe we should give this rule a property to enable/disable something like a "strict" mode?

[adangel]

Fixed with PMD 7

[blacelle]

Where is PMD7? Latest seems 6.42.0 https://mvnrepository.com/artifact/net.sourceforge.pmd/pmd

[oowekyala]

@blacelle PMD 7 is still in development, you can get daily snapshots from sourceforge and the sonatype snapshot repository.

The bug has been fixed in the PMD 7 development branch, but may still be present in PMD 6. I'll reopen the issue with the proper label (we didn't have this procedure yet when this bug was closed).

[adangel]

This has been fixed with PMD 7.0.0-rc1.