Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Rename rule MissingBreakInSwitch to ImplicitSwitchFallThrough #3361

Closed
adangel opened this issue Jun 25, 2021 · 0 comments · Fixed by #3411
Closed

[java] Rename rule MissingBreakInSwitch to ImplicitSwitchFallThrough #3361

adangel opened this issue Jun 25, 2021 · 0 comments · Fixed by #3411
Assignees
Labels
an:enhancement An improvement on existing features / rules is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Milestone

Comments

@adangel
Copy link
Member

adangel commented Jun 25, 2021

That's problem 2 originally described in #2894:

I think the rule's purpose is to avoid implicit fall through to the next case, as this may be unexpected. However the rule's name
just describes its implementation strategy, and not particularly well, as fallthrough may also be avoided by continue, return and
throw statements (cases that the rule tries to handle as well).

Tasks:

  • Rename the rule to ImplicitSwitchFallThrough
  • Deprecated the old rule name MissingBreakInSwitch
@adangel adangel added an:enhancement An improvement on existing features / rules is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them labels Jun 25, 2021
@adangel adangel added this to the 6.37.0 milestone Jun 25, 2021
@adangel adangel self-assigned this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
an:enhancement An improvement on existing features / rules is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant